ECC/skills
Ronaldo Martins ebd8c8c6fa
feat(agents): add Rust language support (#523)
* feat(agents): add Rust language support — reviewer, build resolver, patterns, and testing

Add Rust-specific agents and skills following the established Go/Kotlin pattern:
- agents/rust-reviewer.md: ownership, lifetimes, unsafe audit, clippy, error handling
- agents/rust-build-resolver.md: cargo build errors, borrow checker, dependency resolution
- skills/rust-patterns/SKILL.md: idiomatic Rust patterns and best practices
- skills/rust-testing/SKILL.md: TDD, unit/integration/async/property-based testing

* fix(agents): correct Rust examples for accuracy and consistency

- unsafe fn: add inner unsafe {} block for Rust 2024 edition compliance
- edition: update from 2021 to 2024 as current default
- rstest: add missing fixture import
- mockall: add missing predicate::eq import
- concurrency: use sync_channel (bounded) and expect() over unwrap()
  to align with rust-reviewer's HIGH-priority review checks

* fix(skills): correct compilation issues in Rust code examples

- collect: add .copied() for &str iterator into String
- tokio import: remove unused sleep, keep Duration
- async test: add missing Duration import

* fix(skills): move --no-fail-fast before test-binary args

--no-fail-fast is a Cargo option, not a test binary flag.
Placing it after -- forwards it to the test harness where it is
unrecognized.

* fix(agents): distinguish missing cargo-audit from real audit failures

Check if cargo-audit is installed before running it, so actual
vulnerability findings are not suppressed by the fallback message.

* fix: address automated review findings across all Rust files

- build-resolver: prefer scoped cargo update over full refresh
- testing: add Cargo.toml bench config with harness = false for criterion
- testing: condense TDD example to stay under 500-line limit
- patterns: use expect() over unwrap() on JoinHandle for consistency
- patterns: add explicit lifetime to unsafe FFI return reference
- reviewer: replace misleading "string interpolation" with concrete alternatives

* fix: align with CONTRIBUTING.md conventions

- skills: rename "When to Activate" to "When to Use" per template
- reviewer: add cargo check gate before starting review

* fix(agents): guard cargo-audit and cargo-deny with availability checks

Match the pattern used in rust-build-resolver to avoid command-not-found
errors when optional tools are not installed.

* fix: address second round of automated review findings

- testing: split TDD example into separate code blocks to avoid
  duplicate fn definition in single block
- build-resolver/reviewer: use if/then/else instead of && ... ||
  chaining for cargo-audit/deny to avoid masking real failures
- build-resolver: add MSRV caveat to edition upgrade guidance

* feat: add Rust slash commands for build, review, and test

Add commands/rust-build.md, commands/rust-review.md, and
commands/rust-test.md to provide consistent user entrypoints
matching the existing Go and Kotlin command patterns.

* fix(commands): improve rust-build accuracy and tone

- Restructure-first borrow fix example instead of clone-first
- Realistic cargo test output format (per-test lines, not per-file)
- Align "Parse Errors" step with actual resolver behavior
- Prefer restructuring over cloning in common errors table

* fix: address cubic-dev-ai review findings on commands

- Gate review on all automated checks, not just cargo check
- Use git diff HEAD~1 / git diff main...HEAD for PR file selection
- Fix #[must_use] guidance: Result is already must_use by type
- Remove error-masking fallback on cargo tree --duplicates

* fix: address remaining review findings across all bots

- Add rust-reviewer and rust-build-resolver to AGENTS.md registry
- Update agent count from 16 to 18
- Mark parse_config doctest as no_run (body is todo!())
- Add "How It Works" section to both Rust skills
- Replace cargo install with taiki-e/install-action in CI snippet
- Trim tarpaulin section to stay under 500-line limit

* fix(agents): align rust-reviewer invocation with command spec

- Use git diff HEAD~1 / main...HEAD instead of bare git diff
- Add cargo test as explicit step before review begins

* fix(skills): address cubic review on patterns and testing

- Remove Tokio-specific language from How It Works summary
- Add cargo-llvm-cov install note in coverage section
- Revert no_run on doctest examples (illustrative code, not compiled)

* fix(skills): use expect on thread join for consistency

Replace handle.join().unwrap() with .expect("worker thread panicked")
to match the .expect("mutex poisoned") pattern used above.

* fix(agents): gate review on all automated checks, not just cargo check

Consolidate check/clippy/fmt/test into a single gate step that
stops and reports if any fail, matching the command spec.

* fix(skills): replace unwrap with expect in channel example

Use .expect("receiver disconnected") on tx.send() for consistency
with the .expect() convention used in all other concurrency examples.

* fix: address final review round — OpenCode mirrors, counts, examples

- Add .opencode/commands/rust-{build,review,test}.md mirrors
- Add .opencode/prompts/agents/rust-{build-resolver,reviewer}.txt mirrors
- Fix AGENTS.md count to 20 (add missing kotlin agents to table)
- Fix review example: all checks pass (consistent with gate policy)
- Replace should_panic doctest with is_err() (consistent with best practices)
- Trim testing commands to stay at 500-line limit

* fix: address cubic and greptile review on OpenCode files and agents

- Fix crate::module import guidance (internal path, not Cargo.toml)
- Add cargo fmt --check to verification steps
- Fix TDD GREEN example to handle error path (validate(input)?)
- Scope .context() guidance to anyhow/eyre application code
- Update command count from 40 to 51
- Add tokio channel variants to unbounded channel warning
- Preserve JoinError context in spawned task panic message

* fix: stale command count, channel guidance, cargo tree fallback

- Fix stale command count in Project Structure section (40→51)
- Clarify unbounded channel rule: context-appropriate bounded alternatives
- Remove dead cargo tree fallback (exits 0 even with no duplicates)
- Sync OpenCode reviewer mirror with tokio channel coverage
2026-03-16 13:34:25 -07:00
..
agent-harness-construction feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
agentic-engineering feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
ai-first-engineering feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
android-clean-architecture fix: address PR review comments for Kotlin/Android/KMP docs 2026-03-10 20:53:39 -07:00
api-design fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
article-writing feat: add generic content and investor skills 2026-02-27 05:50:23 -08:00
autonomous-loops feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
backend-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
blueprint docs: tighten blueprint install guidance 2026-03-10 19:23:00 -07:00
carrier-relationship-management docs: resolve remaining operational skill comments 2026-03-10 21:13:55 -07:00
claude-api feat: add orchestration workflows and harness skills 2026-03-12 14:49:05 -07:00
clickhouse-io fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
coding-standards fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
compose-multiplatform-patterns docs: tighten kotlin support examples 2026-03-10 20:53:39 -07:00
configure-ecc feat: orchestration harness, selective install, observer improvements 2026-03-14 12:55:25 -07:00
content-engine feat: add generic content and investor skills 2026-02-27 05:50:23 -08:00
content-hash-cache-pattern fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
continuous-agent-loop feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
continuous-learning feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
continuous-learning-v2 fix: harden observer hooks and test discovery (#513) 2026-03-15 21:47:15 -07:00
cost-aware-llm-pipeline fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
cpp-coding-standards fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
cpp-testing chore: replace external repo links with @username attribution 2026-03-03 12:32:35 -08:00
crosspost feat: orchestration harness, selective install, observer improvements 2026-03-14 12:55:25 -07:00
customs-trade-compliance docs: resolve operational skill review issues 2026-03-10 21:07:36 -07:00
database-migrations fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
deep-research feat: add orchestration workflows and harness skills 2026-03-12 14:49:05 -07:00
deployment-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
django-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
django-security fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
django-tdd fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
django-verification fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
dmux-workflows fix: address remaining orchestration review comments 2026-03-12 15:34:05 -07:00
docker-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
e2e-testing fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
energy-procurement docs: resolve operational skill review issues 2026-03-10 21:07:36 -07:00
enterprise-agent-ops feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
eval-harness feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
exa-search feat: orchestration harness, selective install, observer improvements 2026-03-14 12:55:25 -07:00
fal-ai-media feat: orchestration harness, selective install, observer improvements 2026-03-14 12:55:25 -07:00
foundation-models-on-device fix(skills): improve code examples in iOS 26 skills 2026-02-24 14:39:25 +09:00
frontend-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
frontend-slides chore: replace external repo links with @username attribution 2026-03-03 12:32:35 -08:00
golang-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
golang-testing fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
inventory-demand-planning docs: resolve remaining operational skill comments 2026-03-10 21:13:55 -07:00
investor-materials feat: add generic content and investor skills 2026-02-27 05:50:23 -08:00
investor-outreach feat: add generic content and investor skills 2026-02-27 05:50:23 -08:00
iterative-retrieval fix: harden hook portability and plugin docs 2026-03-09 22:49:43 -07:00
java-coding-standards fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
jpa-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
kotlin-coroutines-flows docs: tighten kotlin support examples 2026-03-10 20:53:39 -07:00
kotlin-exposed-patterns feat: add kotlin commands and skill pack 2026-03-10 21:25:52 -07:00
kotlin-ktor-patterns feat: add kotlin commands and skill pack 2026-03-10 21:25:52 -07:00
kotlin-patterns feat: add kotlin commands and skill pack 2026-03-10 21:25:52 -07:00
kotlin-testing fix: align kotlin diagnostics and heading hierarchy 2026-03-12 23:53:23 -07:00
liquid-glass-design fix(skills): improve code examples in iOS 26 skills 2026-02-24 14:39:25 +09:00
logistics-exception-management docs: resolve operational skill review issues 2026-03-10 21:07:36 -07:00
market-research feat: add generic content and investor skills 2026-02-27 05:50:23 -08:00
nanoclaw-repl feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
nutrient-document-processing feat: add security guides and sanitize external links across repo 2026-02-25 07:20:42 -08:00
perl-patterns docs: tighten perl support guidance 2026-03-10 20:42:54 -07:00
perl-security docs: tighten perl support guidance 2026-03-10 20:42:54 -07:00
perl-testing feat: add Perl skills (patterns, security, testing) 2026-03-10 20:42:54 -07:00
plankton-code-quality feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
postgres-patterns chore: replace external repo links with @username attribution 2026-03-03 12:32:35 -08:00
production-scheduling docs: resolve operational skill review issues 2026-03-10 21:07:36 -07:00
project-guidelines-example fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
prompt-optimizer feat(skills): add prompt-optimizer skill and /prompt-optimize command (#418) 2026-03-12 23:40:02 -07:00
python-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
python-testing fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
quality-nonconformance docs: resolve operational skill review issues 2026-03-10 21:07:36 -07:00
ralphinho-rfc-pipeline feat: deliver v1.8.0 harness reliability and parity updates 2026-03-04 14:48:06 -08:00
regex-vs-llm-structured-text fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
returns-reverse-logistics docs: resolve remaining operational skill comments 2026-03-10 21:13:55 -07:00
rust-patterns feat(agents): add Rust language support (#523) 2026-03-16 13:34:25 -07:00
rust-testing feat(agents): add Rust language support (#523) 2026-03-16 13:34:25 -07:00
search-first feat: separate core vs niche skills and enforce research-first default 2026-02-28 10:06:43 -08:00
security-review fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
security-scan fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
skill-stocktake docs: add skill-stocktake agent invocation example 2026-03-10 20:15:38 -07:00
springboot-patterns fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
springboot-security fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
springboot-tdd fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
springboot-verification fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
strategic-compact feat: add orchestration workflows and harness skills 2026-03-12 14:49:05 -07:00
swift-actor-persistence fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
swift-concurrency-6-2 fix(skills): improve code examples in iOS 26 skills 2026-02-24 14:39:25 +09:00
swift-protocol-di-testing fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
swiftui-patterns fix: correct SwiftUI skill ViewModel injection and Equatable comparison 2026-02-17 17:04:31 +02:00
tdd-workflow fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
verification-loop fix: add origin metadata to skills for traceability 2026-02-23 19:00:57 +03:00
video-editing feat: add orchestration workflows and harness skills 2026-03-12 14:49:05 -07:00
videodb feat: add /aside command (#407) 2026-03-12 23:52:46 -07:00
visa-doc-translate feat(skills): add visa-doc-translate skill 2026-02-20 16:25:23 +08:00
x-api fix: harden orchestration status and skill docs 2026-03-12 15:07:57 -07:00