mirror of
https://github.com/Jeuners/ECC.git
synced 2026-09-09 15:02:30 +02:00
0071fa5c3c
* refactor(hooks): consolidate PostToolUse hooks into sync/async dispatchers Replace 10 individual PostToolUse entries in hooks.json with two consolidated dispatcher entries (post:dispatcher:sync / post:dispatcher:async). The dispatcher's internal registry preserves every hook ID, matcher, and profile, so ECC_DISABLED_HOOKS and ECC_HOOK_PROFILE gating behave exactly as before. Performance (Edit event, actual hooks.json commands spawned in parallel like the harness does, median of 7 runs): - Blocking hook latency: 81ms -> 49ms (~40% faster; 7 blocking processes -> 1 sync dispatcher) - Node processes per tool call: 10 -> 2 (7 blocking + 3 async -> 1 sync + 1 async) - observe-runner now runs in-process (~370ms) inside the async dispatcher, which stays backgrounded (async: true, timeout 45s), so it adds no user-facing latency. Also: - dashboard-web lists dispatcher-managed child hooks so the hook inventory stays complete - post-edit-console-warn refactored to export run() for in-process dispatch while keeping standalone stdin behavior - dispatcher stdin reading is multi-byte safe (StringDecoder) and child hook exit codes propagate to the dispatcher exit code * test(hooks): replace emoji literal with unicode escape for CI unicode safety check * fix(hooks): adopt explicit cli() entrypoint and merge multi-hook stdout Address Greptile review on #2494: - Replace the non-standard 'require.main === undefined' guard with an explicit exported cli(). The hooks.json bootstraps now call require(s).cli(), so merely requiring the module (dashboard-web, test runners, Jest, worker threads) can never trigger dispatch, attach stdin listeners, or set process.exitCode. - Replace last-writer-wins stdout with mergeHookStdout(): when several hooks emit additionalContext envelopes they merge into a single PostToolUse envelope; non-mergeable raw stdout keeps the last hook's output and emits a stderr warning naming the dropped hook IDs, so nothing is lost silently. Also includes local formatter reformatting of the dispatcher and its test file (no behavioral changes beyond the above). * fix(hooks): keep post:bash:dispatcher phase reachable in minimal profile The Greptile P1 premise was partially incorrect: sub-hooks without explicit profiles default to standard,strict via parseProfiles() (scripts/lib/hook-flags.js), so audit/cost logs never ran under the minimal profile on main either — there is no user-visible regression. However, main did spawn the bash dispatcher phase unconditionally and let each sub-hook gate itself. Restore that semantic by opening the outer registry gate to minimal,standard,strict so a future sub-hook that opts into minimal is not silently blocked at the phase level. Adds the previously missing minimal-profile async dry-run test. * test(hooks): assert failing hook exit code propagates to real process status Spawns the actual dispatcher subprocess with an injected failing hook and asserts the OS-level exit status, stderr diagnostic, and suppressed pass-through — closing the E2E gap CodeRabbit flagged on #2494. * chore: retrigger CI (flaky windows powershell bootstrap test) |
||
|---|---|---|
| .. | ||
| aside.md | ||
| auto-update.md | ||
| build-fix.md | ||
| checkpoint.md | ||
| code-review.md | ||
| cost-report.md | ||
| cpp-build.md | ||
| cpp-review.md | ||
| cpp-test.md | ||
| ecc-guide.md | ||
| epic-claim.md | ||
| epic-decompose.md | ||
| epic-publish.md | ||
| epic-review.md | ||
| epic-sync.md | ||
| epic-unblock.md | ||
| epic-validate.md | ||
| evolve.md | ||
| fastapi-review.md | ||
| feature-dev.md | ||
| flutter-build.md | ||
| flutter-review.md | ||
| flutter-test.md | ||
| gan-build.md | ||
| gan-design.md | ||
| go-build.md | ||
| go-review.md | ||
| go-test.md | ||
| gradle-build.md | ||
| harness-audit.md | ||
| hookify-configure.md | ||
| hookify-help.md | ||
| hookify-list.md | ||
| hookify.md | ||
| instinct-export.md | ||
| instinct-import.md | ||
| instinct-status.md | ||
| jira.md | ||
| kotlin-build.md | ||
| kotlin-review.md | ||
| kotlin-test.md | ||
| learn-eval.md | ||
| learn.md | ||
| loop-start.md | ||
| loop-status.md | ||
| marketing-campaign.md | ||
| model-route.md | ||
| multi-backend.md | ||
| multi-execute.md | ||
| multi-frontend.md | ||
| multi-plan.md | ||
| multi-workflow.md | ||
| orch-add-feature.md | ||
| orch-build-mvp.md | ||
| orch-change-feature.md | ||
| orch-fix-defect.md | ||
| orch-refine-code.md | ||
| orch-review.md | ||
| plan-canvas.md | ||
| plan-prd.md | ||
| plan.md | ||
| pm2.md | ||
| pr.md | ||
| project-init.md | ||
| projects.md | ||
| promote.md | ||
| prp-commit.md | ||
| prp-implement.md | ||
| prp-plan.md | ||
| prp-pr.md | ||
| prp-prd.md | ||
| prune.md | ||
| python-review.md | ||
| quality-gate.md | ||
| react-build.md | ||
| react-review.md | ||
| react-test.md | ||
| refactor-clean.md | ||
| resume-session.md | ||
| review-pr.md | ||
| rust-build.md | ||
| rust-review.md | ||
| rust-test.md | ||
| santa-loop.md | ||
| save-session.md | ||
| security-scan.md | ||
| sessions.md | ||
| setup-pm.md | ||
| skill-create.md | ||
| skill-health.md | ||
| test-coverage.md | ||
| update-codemaps.md | ||
| update-docs.md | ||
| vue-review.md | ||