ECC/rules/common
konstapukarifastnetfi 8b24f63ede
fix: refresh stale technical content in agents, rules, and skills (#2168)
Several published examples contained APIs that no longer exist, code that
does not run, or model versions that drifted from reality:

- agents/performance-optimizer.md used the web-vitals v3 API
  (getCLS/getFID/getLCP/getFCP/getTTFB) and reported FID. web-vitals v4
  renamed the imports to onCLS/onINP/onLCP/onFCP/onTTFB and FID was
  replaced by INP (target < 200ms)
- rules/common/performance.md pinned stale model versions in the
  model-selection guidance; refresh to the versions the repo itself uses
  (agent.yaml pins claude-opus-4-6) and add the PowerShell variant for
  MAX_THINKING_TOKENS next to the bash export
- skills/python-patterns/SKILL.md: both get_value examples referenced
  default_value without declaring the parameter (NameError); add
  default_value: Any = None to the EAFP and LBYL signatures
- skills/frontend-patterns/SKILL.md: the custom useQuery example rebuilt
  refetch whenever callers passed inline fetchers/options, re-triggering
  the effect after every state update (infinite fetch loop). Keep the
  latest fetcher/options in refs so refetch stays referentially stable.
  The PASS-labelled useMemo example mutated its input with in-place sort;
  copy before sorting
- skills/coding-standards/SKILL.md repeated the same PASS-labelled
  in-place-sort-in-useMemo example; same fix
- rules/typescript/security.md used a vendor-specific OPENAI_API_KEY in
  generic guidance; switch to a neutral API_KEY

Every hand-maintained copy of the affected content is synced in the same
change: locale mirrors (ja-JP, ko-KR, pt-BR, tr, zh-CN, zh-TW - each only
where it carries the affected file) and the .agents/.kiro/.cursor harness
mirrors. Two structural divergences are left alone and noted here:
.kiro/steering/performance.md has no extended-thinking control list to
carry the PowerShell variant, and docs/zh-TW/rules/performance.md keeps an
older condensed thinking section without the budget-cap line.
rules/zh/performance.md is intentionally untouched - the rules/zh tree is
being retired in a separate change
2026-06-07 13:26:01 +08:00
..
agents.md docs: salvage HarmonyOS ArkTS guidance 2026-05-11 21:28:15 -04:00
code-review.md fix: address review feedback from PR #929 2026-03-26 04:37:08 +00:00
coding-style.md docs: fold stocktake rule guidance into common rules 2026-04-05 15:49:43 -07:00
development-workflow.md fix: address review feedback from PR #929 2026-03-26 04:37:08 +00:00
git-workflow.md refactor(rules): split Feature Implementation Workflow from git-workflow.md (refs #235) 2026-02-24 13:41:19 +05:30
hooks.md refactor(rules): restructure into common + language-specific directories 2026-02-05 05:58:06 -08:00
patterns.md refactor(rules): restructure into common + language-specific directories 2026-02-05 05:58:06 -08:00
performance.md fix: refresh stale technical content in agents, rules, and skills (#2168) 2026-06-07 13:26:01 +08:00
security.md refactor(rules): restructure into common + language-specific directories 2026-02-05 05:58:06 -08:00
testing.md docs: fold stocktake rule guidance into common rules 2026-04-05 15:49:43 -07:00