ECC/skills/continuous-learning-v2
Albert Lie 이영덕 b57b573085
fix(continuous-learning-v2): add lazy-start observer logic (#508)
* feat(continuous-learning-v2): add lazy-start observer logic

Auto-starts observer when observer.enabled: true in config and no .observer.pid exists.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(continuous-learning-v2): address PR review concerns

- Use flock for atomic check-then-act to prevent race conditions
- Check both project-scoped AND global PID files before starting
- Support CLV2_CONFIG override for config file path
- Check disabled file in lazy-start logic
- Use double-check pattern after acquiring lock

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(observe.sh): address PR review comments

- Add stale PID cleanup via _CHECK_OBSERVER_RUNNING function
- Add macOS fallback using lockfile when flock unavailable
- Fix CLV2_CONFIG override: use EFFECTIVE_CONFIG for both check and read
- Use proper Python context manager (with open() as f)
- Deduplicate signaled PIDs to avoid duplicate USR1 signals

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(observe.sh): wrap macOS lockfile fallback in subshell with trap

- Wrap lockfile block in subshell so exit 0 only terminates that block
- Add trap for EXIT to clean up lock file on script interruption
- Add -l 30 (30 second expiry) to prevent permanent lock file stuck

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(observe.sh): address remaining PR review comments

- Validate PID is a positive integer before kill calls to prevent
  signaling invalid targets (e.g. -1 could signal all processes)
- Pass config path via env var instead of interpolating shell variable
  into Python -c string to prevent injection/breakage on special paths
- Check CLV2_CONFIG-derived directory for disabled file so disable
  guard respects the same config source as lazy-start

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-16 13:38:20 -07:00
..
agents feat: orchestration harness, selective install, observer improvements 2026-03-14 12:55:25 -07:00
hooks fix(continuous-learning-v2): add lazy-start observer logic (#508) 2026-03-16 13:38:20 -07:00
scripts fix: harden observer prompt guard handling 2026-03-12 23:59:01 -07:00
config.json feat: project-scoped instinct isolation 2026-03-01 12:07:13 -08:00
SKILL.md fix: repair opencode config and project metadata 2026-03-11 01:52:10 -07:00