dillenberg/ECC
1
0
Fork 0
mirror of https://github.com/Jeuners/ECC.git synced 2026-09-09 15:02:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(hooks): require successful shell probe in observe runner (#2403)

Browse source 
Require observe-runner shell detection to accept only candidates whose probe exits successfully, avoiding Windows WSL launcher false positives.
This commit is contained in:
JongHyeok Park 2026-07-14 10:31:12 +09:00 • committed by GitHub
parent 40927950c4
commit ed38744605
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
scripts/hooks/observe-runner.js
View file

@ -61,7 +61,10 @@ function findShellBinary() {
stdio: 'ignore',
windowsHide: true
});
if (!probe.error) {
// Require the probe to actually succeed, not just spawn: Windows'
// System32\bash.exe (WSL launcher) spawns even with no distro installed but
// exits non-zero, so `!probe.error` alone would treat it as a usable shell.
if (!probe.error && probe.status === 0) {
return candidate;
}
}