dillenberg/ECC
1
0
Fork 0
mirror of https://github.com/Jeuners/ECC.git synced 2026-09-18 11:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: surface warn-only PreToolUse hooks (#2084)

Browse source
This commit is contained in:
Affaan Mustafa 2026-05-28 07:45:46 -04:00 • committed by GitHub
parent 04c68e483a
commit 64cd1ba248
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 143 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/hooks/bash-hook-dispatcher.test.js
View file

@ -35,6 +35,10 @@ function runScript(scriptPath, input, env = {}) {
});
}
function parseHookOutput(stdout) {
return JSON.parse(stdout);
}
function runTests() {
console.log('\n=== Testing Bash hook dispatchers ===\n');
@ -54,13 +58,18 @@ function runTests() {
const enabled = runScript(preDispatcher, input, { ECC_HOOK_PROFILE: 'strict' });
assert.strictEqual(enabled.status, 0);
assert.ok(enabled.stderr.includes('Review changes before push'), 'Expected git push reminder when enabled');
assert.strictEqual(enabled.stderr, '', `Expected visible reminder via stdout JSON, got stderr: ${enabled.stderr}`);
assert.ok(
parseHookOutput(enabled.stdout).hookSpecificOutput.additionalContext.includes('Review changes before push'),
'Expected git push reminder when enabled'
);
const disabled = runScript(preDispatcher, input, {
ECC_HOOK_PROFILE: 'strict',
ECC_DISABLED_HOOKS: 'pre:bash:git-push-reminder',
});
assert.strictEqual(disabled.status, 0);
assert.strictEqual(disabled.stdout, JSON.stringify(input), 'Disabled hook should pass through original input');
assert.ok(!disabled.stderr.includes('Review changes before push'), 'Disabled hook should not emit reminder');
})) passed++; else failed++;